Make increment! nil-attribute expectation depend on Rails version - #112
Open
datibbaw wants to merge 1 commit into
Open
Make increment! nil-attribute expectation depend on Rails version#112datibbaw wants to merge 1 commit into
increment! nil-attribute expectation depend on Rails version#112datibbaw wants to merge 1 commit into
Conversation
Rails 8.1 added new_record?/destroyed? guards to increment!, so it now raises ActiveRecordError before reaching typedstore's attribute handling. Older Rails still raises ActiveModel::MissingAttributeError. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails 8.1 added
new_record?/destroyed?guards toincrement!, so it now raisesActiveRecordErrorbefore reaching the gem's attribute handling. Older Rails still raisesActiveModel::MissingAttributeError.