Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wasi-common from runner crate #907

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

jeffcharles
Copy link
Collaborator

Description of the change

Switch from wasi-common to wasmtime-wasi in runner crate. This change includes taking stdin in tests as Vec<u8> instead of a byte slice because MemoryInputStream::new takes a Vec<u8> instead of a byte slice. I've also deleted LogWriter because MemoryOutputStream accepts a capacity limit as an argument.

Why am I making this change?

We want to standardize on using wasmtime-wasi.

Checklist

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-plugin do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

@jeffcharles jeffcharles requested a review from saulecabrera March 7, 2025 22:50
@jeffcharles jeffcharles merged commit 0455688 into main Mar 7, 2025
4 checks passed
@jeffcharles jeffcharles deleted the jc.remove-wasi-common-from-runner branch March 7, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants