Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dump_wat feature from codegen #908

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Remove dump_wat feature from codegen #908

merged 1 commit into from
Mar 7, 2025

Conversation

jeffcharles
Copy link
Collaborator

Description of the change

Removes the dump_wat feature from the codegen crate.

Why am I making this change?

We don't really use it any more and I don't want to commit to supporting it. It simplifies the code a bit.

Checklist

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-plugin do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

@jeffcharles jeffcharles requested a review from saulecabrera March 7, 2025 23:00
@jeffcharles jeffcharles enabled auto-merge (squash) March 7, 2025 23:04
@jeffcharles jeffcharles merged commit 05dee64 into main Mar 7, 2025
4 checks passed
@jeffcharles jeffcharles deleted the jc.remove-dump-wat-feature branch March 7, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulecabrera saulecabrera saulecabrera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffcharles @saulecabrera