-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add versioning support and update CMake configuration #3933
Conversation
47f18d0
to
c38af70
Compare
@jirutka Please inform me if platforms other than Linux require the SONAME feature. |
The same applies to all Unix and Unix-like systems, so also BSDs and macOS. |
maybe you can do it for all platforms and let cmake do whatever appropriate? |
build-tested for macOS. master:
with this PR:
iirc, on macOS, a dylib can be loaded if
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks reasonable to me
bd64d74
to
db69420
Compare
@yamt @loganek @TianlongLiang @xujuntwt95329 @wenyongh @no1wudi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7bcdcf5
to
382f39e
Compare
382f39e
to
3b0dfae
Compare
…droid compilation workflow
da837cd
to
4e97498
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, this looks good to me.
No description provided.