Use quoted identifiers in wasmprinter
by default
#1615
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates
wasmprinter
to use quoted identifiers of the form$"foo"
when necessary instead of synthesizing identifiers such as$#func4<foo>
. This helps produce more readable modules by default when names are synthesized since if a name is unique but otherwise has non-identifier characters then the quoted string form can be used.While here I've additionally changed the way that non-printable characters in strings are printed to using
\u{XXX}
syntax instead of\NN
syntax. This makes it a bit more obvious in unicode contexts that a single character is present and not multiple.For a module I was looking at the "before" was:
and the "after" is:
Notably
$"initialize(char const*)"
is much nicer to raed