Reduce dependencies of wasm-metadata
#2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This crate is depended on by `wit-component` which shows up in a lot of places, but most of the dependencies of `wasm-metadata` are not needed for `wit-component`. This commit gates most of the OCI-related information behind a compile-time `oci` feature which is enabled by default. The workspace dependency now disables default features and only the CLI itself enables the default features of `wasm-metadata`.
yoshuawuyts
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate is depended on by
wit-componentwhich shows up in a lot of places, but most of the dependencies ofwasm-metadataare not needed forwit-component. This commit gates most of the OCI-related information behind a compile-timeocifeature which is enabled by default. The workspace dependency now disables default features and only the CLI itself enables the default features ofwasm-metadata.