wasmparser: add a hint to out-of-bounds type indices errors
#2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an out-of-bounds type index would be in bounds if the GC proposal was enabled, but it is not, add some extra verbiage to the error message explaining that. This is useful for people who are playing around with Wasm GC in Wasmtime, but forget to enable it on the CLI or in their config. I've taken care to only *add* to the error message, so that the substring matching we use for `.wast` tests will continue to work.
alexcrichton
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an out-of-bounds type index would be in bounds if the GC proposal was enabled, but it is not, add some extra verbiage to the error message explaining that. This is useful for people who are playing around with Wasm GC in Wasmtime, but forget to enable it on the CLI or in their config.
I've taken care to only add to the error message, so that the substring matching we use for
.wasttests will continue to work.