Skip to content

chore: remove redundant word in comment #10723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

whosehang
Copy link

remove redundant word in comment

@whosehang whosehang requested a review from a team as a code owner May 3, 2025 15:11
@whosehang whosehang requested review from dicej and removed request for a team May 3, 2025 15:11
@github-actions github-actions bot added wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:c-api Issues pertaining to the C API. labels May 3, 2025
@cfallin
Copy link
Member

cfallin commented May 3, 2025

The find-and-replace substituting "in in line asm" to "in line asm", and the edits to WIT files that are vendored and thus now fail a CI check to ensure they are unmodified, together with a history of this account making wide-ranging refactors across many projects in ways that show similar lack of careful work, lead me to suggest that we close this PR. While typo fixes are generally welcome, it's really not worth maintainers' time if it is done in a sloppy way that breaks things, and I don't want to encourage this pattern.

(I don't want to unilaterally make this decision though -- someone else please check me here; and perhaps we should have a project policy on this, as these "drive-by fix" PRs are becoming more and more frequent)

@whosehang
Copy link
Author

The find-and-replace substituting "in in line asm" to "in line asm", and the edits to WIT files that are vendored and thus now fail a CI check to ensure they are unmodified, together with a history of this account making wide-ranging refactors across many projects in ways that show similar lack of careful work, lead me to suggest that we close this PR. While typo fixes are generally welcome, it's really not worth maintainers' time if it is done in a sloppy way that breaks things, and I don't want to encourage this pattern.

(I don't want to unilaterally make this decision though -- someone else please check me here; and perhaps we should have a project policy on this, as these "drive-by fix" PRs are becoming more and more frequent)

Sorry for the confusion. I respect your suggestions, but before that, I will still make the changes as advised by @primoly.

Please feel free to close this PR casually.

@whosehang whosehang requested a review from a team as a code owner May 4, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:c-api Issues pertaining to the C API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants