-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update CLI run
documentation
#10793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CLI run
documentation
#10793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the nits!
docs/cli-options.md
Outdated
|
||
A Wasm **module** exports raw functions directly. The `run` command accepts an optional `--invoke` argument, which is the name of an exported raw function (of the module) to run: | ||
WebAssembly modules or components can behave like a "command" which means |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering: isn't there some WASI repository page somewhere that we can link to here in case anyone wants to dig into the difference between command and reactor components?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @abrown ,
I think this was mentioned in this comment - WebAssembly/WASI#13 (comment)
So i think this the right repository - https://github.com/WebAssembly/component-model
There is post on blog for this topic which helped me to understand this topic - https://wasmcloud.com/blog/webassembly-patterns-command-reactor-library/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update this to remove the "command" terminology since that's now-dated and instead just say "CLI program" in a few places here. I'd prefer to not have to bring up commands/reactors if possible since they're ideally only a historical feature.
Try to take the spirit of bytecodealliance#10792 to improve our documentation for the `run` command and how CLI arguments interact with the provided WebAssembly module.
3826dd8
to
6b3cc3b
Compare
Try to take the spirit of #10792 to improve our documentation for the
run
command and how CLI arguments interact with the provided WebAssembly module.