Reduce number of locations host page size comes from #10803
+112
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
wasmtime:api
pchickey
approved these changes
May 19, 2025
Currently Wasmtime has a function `crate::runtime::vm::host_page_size` but this is only used sometimes and the rest of the time `rustix::param::page_size` is used in a few locations. It looks like this usage of `rustix` is causing a panic in bytecodealliance#10802 and additionally it's best to only have one source for this, so this commit updates this all to route through our preexisting `host_page_size` function.
alexcrichton
force-pushed
the
remove-rustix-page-size
branch
from
2f4bbc6 to
37e8216
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Wasmtime has a function
crate::runtime::vm::host_page_sizebut this is only used sometimes and the rest of the timerustix::param::page_sizeis used in a few locations. It looks like this usage ofrustixis causing a panic in #10802 and additionally it's best to only have one source for this, so this commit updates this all to route through our preexistinghost_page_sizefunction.