Minor optimizations to assembler-generated code #10811
Merged
+76
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a few minor changes in the hopes of optimizing the compile-time of the generated code itself for the x64 assembler crate, including: * Add `derive(Copy)` to all instructions to benefit from a specialized implementation of `derive(Clone)` when a `Copy` implementation is also present (e.g. it's `*foo` instead of a structural `clone`-each-field). * Don't use `write!` in `Display for Inst` and instead delegate directly with methods to avoid formatting machinery. * Use helper methods in `RegisterVisitor` trait to have register allocation be a method-per-operand and shrink the methods a bit.
|
This doesn't have a big impact on compile-time right now, nor am I confident that it'll have an impact long-term, so @abrown if you'd prefer I'm also ok to just close this and/or drop parts of it. |
github-actions
bot
added
the
cranelift
abrown
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a few minor changes in the hopes of optimizing the compile-time of the generated code itself for the x64 assembler crate, including:
derive(Copy)to all instructions to benefit from a specialized implementation ofderive(Clone)when aCopyimplementation is also present (e.g. it's*fooinstead of a structuralclone-each-field).write!inDisplay for Instand instead delegate directly with methods to avoid formatting machinery.RegisterVisitortrait to have register allocation be a method-per-operand and shrink the methods a bit.