Fix atomic wait expected values on big-endian hosts - #14027
Open
subotac wants to merge 1 commit into
Open
Conversation
alexcrichton
approved these changes
Jul 30, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 30, 2026
github-actions
Bot
added
the
wasmtime:api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13988.
WebAssembly linear memory is little-endian, while the native atomic views used by shared memory follow host endianness. Convert the expected wait32 and wait64 values at that boundary so comparisons use the same byte
representation on big-endian hosts.
Add the issue's wait32/wait64 regression cases and exclude the test from the pooling configuration, which does not support shared memory.
Tests:
cargo test --test wast -- atomic_wait_endiannesscargo test --test wast -- threadscargo fmt -p wasmtime -p wasmtime-test-util -- --check