fuzzgen: Always generate reachable blocks #5034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cranelift
jameysharp
reviewed
Oct 12, 2022
There was a problem hiding this comment.
I used all my brain today on reviewing the egraphs PR and can't give this the attention I'd like to. @cfallin, could you verify that this implementation of CFG generation makes sense to you, and merge this if so?
Certainly; I owe you several brain refills for that review, thanks! I'll take a look at this PR tomorrow. |
Thanks @jameysharp! Co-authored-by: Jamey Sharp <[email protected]>
cfallin
reviewed
Oct 12, 2022
cfallin
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This PR alters fuzzgen to always generate reachable blocks. See #5022 for context.
We do this by making sure that whenever we insert terminators at least one of the edges points to the next block.
Another thing this PR does is separate the CFG construction from block terminator insertion.
This fuzzed ok individually, but I'm now also testing with #5020 on top to see if it finds anything else.
cc: @jameysharp