refactor(tarko): simplify chat state management and fix streaming thinking flickering#1293
Closed
ulivz wants to merge 1 commit into
Closed
refactor(tarko): simplify chat state management and fix streaming thinking flickering#1293ulivz wants to merge 1 commit into
ulivz wants to merge 1 commit into
Conversation
✅ Deploy Preview for agent-tars-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
Duplicate of #1293 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored Chat state management to fix
AssistantStreamingThinkingMessageflickering issue while simplifying the overall architecture.Key Changes:
BaseMessageHandlerclass for consistent update logicsortedMessagesAtomfor basic time-sorted messagesThinkingMessageHandlerwith stable messageId-based logicProblem Solved:
The previous refactor in commit
5968a43ecausedAssistantStreamingThinkingMessageto flicker during streaming, which was reverted in8bb3236. This PR provides a stable solution that prevents flickering while maintaining simplified state management.Checklist