fix(tarko): handle open_computer action normalization#1305
Merged
Conversation
Treat open_computer() as wait action instead of click with 0,0 coordinates Prevents incorrect startX/startY values in normalizedAction response
✅ Deploy Preview for agent-tars-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Instead of falling back to click action, preserve original action type with empty inputs for unknown actions like open_computer()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue where
open_computer()action returns incorrectstartX: 0andstartY: 0coordinates innormalizedActionresponse, this causes the web ui to render incorrectly:The problem was in
convertToNormalizedActionfunction in@tarko/shared-utilswhere unknown action types fell back to click action with zero coordinates.Root Cause: Unknown action types like
open_computerwere being converted to click actions withstartX: 0, startY: 0.Solution: Modified the default case to preserve the original action type with empty inputs instead of falling back to click action.
Changes:
convertToNormalizedActionto return raw action typeopen_computer()returns{ type: 'open_computer', inputs: {} }instead of{ type: 'click', inputs: { startX: 0, startY: 0 } }Ref: #1295
Checklist