feat(tarko): support real data file uploads - #1942
Open
SC123667 wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for agent-tars-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for tarko ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uploads/in the current Agent workspace through a new/api/v1/files/uploadendpointWhy
The file picker previously accepted only images, and the change handler silently ignored every non-image file. The UI could therefore look as if a data file had been selected even though no bytes reached the Agent workspace.
This implementation is based on current
mainand follows the current/api/v1and CSRF conventions. It is also a current-main alternative related to #1557 while keeping image attachments on their existing client-side path.Fixes #323.
Validation
pnpm install --frozen-lockfilepnpm bootstrappnpm test— 842 passed, 13 skippedpnpm --filter @tarko/agent-server test— 66 passedpnpm --filter @tarko/agent-ui test— 4 passedpnpm --filter @tarko/agent-server run buildpnpm --filter @tarko/agent-ui run buildgit diff --check