Skip to content

Conversation

@ZacBlanco
Copy link
Collaborator

@ZacBlanco ZacBlanco commented Dec 12, 2025

What problem does this PR solve?

Adds missing CI jobs which are critical to ensuring bolt's functionality is correct.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🚀 Performance improvement (optimization)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🔨 Refactoring (no logic changes)
  • 🔧 Build/CI or Infrastructure changes
  • 📝 Documentation only

Description

  1. Adds a benchmarks-build job to ensure benchmarks are always buildable. We don't need to run the benchmarks in CI because the environment is not stable enough to ensure consistent performance. It is up to users to run them. CI needs to just make sure they are not broken.
  2. Adds release_spark to build matrix alongside release. The bolt backend is a critical part of the Gluten project. And when users build bolt for gluten they should be building with the release_spark target. This ensures that we build and test with the Gluten-compatible profile so that we know it always works.
  3. Refactors the build-test action to have a common setup composite workflow
  4. Fixes the CI image to put the python venv bin on the path first so the venv python and pip, and other installed pip-installed package binaries are available without having to source or activate the venv within the CI image

Performance Impact

N/A

Release Note

N/A

Checklist (For Author)

  • I have added/updated unit tests (ctest).
  • I have verified the code with local build (Release/Debug).
  • I have run clang-format / linters.
  • (Optional) I have run Sanitizers (ASAN/TSAN) locally for complex C++ changes.
  • No need to test or manual test.

Breaking Changes

  • No
  • Yes (Description: ...)

@ZacBlanco ZacBlanco force-pushed the zac-debug-build-test branch 6 times, most recently from 79a1972 to 10d1e7d Compare December 12, 2025 01:08
@ZacBlanco ZacBlanco changed the title ci: Add debug to build-test matrix ci: Add benchmark to build-test workflow Dec 16, 2025
@ZacBlanco ZacBlanco force-pushed the zac-debug-build-test branch from 63bf28b to 5826bf1 Compare December 16, 2025 16:58
@ZacBlanco ZacBlanco changed the title ci: Add benchmark to build-test workflow ci: Add benchmark and release_spark to build-test workflow Dec 16, 2025
@ZacBlanco ZacBlanco marked this pull request as ready for review December 16, 2025 18:59
@ZacBlanco ZacBlanco force-pushed the zac-debug-build-test branch 7 times, most recently from f90d8a3 to db939ec Compare December 18, 2025 06:12
@ZacBlanco ZacBlanco requested a review from kexianda December 18, 2025 06:13
@ZacBlanco ZacBlanco requested a review from kexianda December 19, 2025 18:55
- virtualenv stored in /opt/venv now
- /opt/venv/bin now first on path
- remove unnecessary statements in bashrc/profile
- tag CI image with date for tracking
and to be able to test before merging
- remove unnecessary steps in actions workflow setup
@ZacBlanco ZacBlanco force-pushed the zac-debug-build-test branch from 1c6ae3a to a458500 Compare December 20, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants