refactor: split function registration files #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps make the build more stable by not ballooning memory on this one file. Most of the compilation time is due to heavy use of templates. Since we don't intend to change the registration process, just split this into smaller files
Restructure arithmetic function registrations into a more organized hierarchy with clear categories. Replace individual registration calls with a unified registerArithmeticFunctions interface. The changes include: - Renaming and reorganizing registration files by arithmetic categories - Make ArithmeticFunctionsRegistration.cpp the main entry point
…le file Move all math function registrations from separate files into RegisterMath.cpp to simplify maintenance and improve code organization
ZacBlanco
force-pushed
the
func-registration.patch
branch
2 times, most recently
from
c8cc1f7 to
5ad1fa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Reduce memory consumption during compilation by splitting files with large use of templates.
Some registration files exceed 10GB of memory and 5 minutes of compilation time due to extensive use of templates. By splitting the function registrations across more files it reduces memory consumption. It can also help stabilize the build in memory-constrained environments and speed up end-to-end build times
Type of Change
Description
Files in registration for math and datetime functions are now split into multiple separate files with individual registraiton functions. The individual registrations are then called in the original files.
No functions should be added or removed.
Release Note
N/A
Checklist (For Author)
Breaking Changes