Skip to content

[cp]fix: Fix incorrect scalar optimization in gatherCopy#328

Open
taiyang-li wants to merge 1 commit intobytedance:mainfrom
taiyang-li:cp_15445
Open

[cp]fix: Fix incorrect scalar optimization in gatherCopy#328
taiyang-li wants to merge 1 commit intobytedance:mainfrom
taiyang-li:cp_15445

Conversation

@taiyang-li
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #191

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🚀 Performance improvement (optimization)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🔨 Refactoring (no logic changes)
  • 🔧 Build/CI or Infrastructure changes
  • 📝 Documentation only

Description

The optimized path for scalar targets in gatherCopy incorrectly assumed all
source vectors were flat, causing failures with encoded vectors such as DictionaryVector.
This PR adds another check to ensure the fast path is now only taken when the target is
scalar and all the sources are flattened.

Corresponding PR: facebookincubator/velox#15445

Performance Impact

  • No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).

  • Positive Impact: I have run benchmarks.

    Click to view Benchmark Results
    Paste your google-benchmark or TPC-H results here.
    Before: 10.5s
    After:   8.2s  (+20%)
    
  • Negative Impact: Explained below (e.g., trade-off for correctness).

Release Note

Please describe the changes in this PR

Release Note:

Release Note:
- https://github.com/facebookincubator/velox/pull/15445

Checklist (For Author)

  • I have added/updated unit tests (ctest).
  • I have verified the code with local build (Release/Debug).
  • I have run clang-format / linters.
  • (Optional) I have run Sanitizers (ASAN/TSAN) locally for complex C++ changes.
  • No need to test or manual test.

Breaking Changes

  • No

  • Yes (Description: ...)

    Click to view Breaking Changes
    Breaking Changes:
    - Description of the breaking change.
    - Possible solutions or workarounds.
    - Any other relevant information.
    

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2026

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants