Skip to content

[cp]refactor: Replace new with make_shared for ThriftInternal#330

Open
taiyang-li wants to merge 10 commits intobytedance:mainfrom
taiyang-li:cp_16136
Open

[cp]refactor: Replace new with make_shared for ThriftInternal#330
taiyang-li wants to merge 10 commits intobytedance:mainfrom
taiyang-li:cp_16136

Conversation

@taiyang-li
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #191

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🚀 Performance improvement (optimization)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🔨 Refactoring (no logic changes)
  • 🔧 Build/CI or Infrastructure changes
  • 📝 Documentation only

Description

refactor: Replace new with make_shared for ThriftInternal

Corresponding PR: facebookincubator/velox#16136

Performance Impact

  • No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).

  • Positive Impact: I have run benchmarks.

    Click to view Benchmark Results
    Paste your google-benchmark or TPC-H results here.
    Before: 10.5s
    After:   8.2s  (+20%)
    
  • Negative Impact: Explained below (e.g., trade-off for correctness).

Release Note

Please describe the changes in this PR

Release Note:

Release Note:
- refactor: Replace new with make_shared for ThriftInternal

Checklist (For Author)

  • I have added/updated unit tests (ctest).
  • I have verified the code with local build (Release/Debug).
  • I have run clang-format / linters.
  • (Optional) I have run Sanitizers (ASAN/TSAN) locally for complex C++ changes.
  • No need to test or manual test.

Breaking Changes

  • No

  • Yes (Description: ...)

    Click to view Breaking Changes
    Breaking Changes:
    - Description of the breaking change.
    - Possible solutions or workarounds.
    - Any other relevant information.
    

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ zhangxffff
✅ guhaiyan0221
✅ weixiuli
❌ beliefer
You have signed the CLA already but the status is still pending? Let us recheck it.

@guhaiyan0221 guhaiyan0221 force-pushed the main branch 2 times, most recently from 906a3a9 to b88fc0e Compare March 4, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants