[feat][cp] Add mode Spark aggregate function#334
Draft
guhaiyan0221 wants to merge 1 commit intobytedance:mainfrom
Draft
[feat][cp] Add mode Spark aggregate function#334guhaiyan0221 wants to merge 1 commit intobytedance:mainfrom
guhaiyan0221 wants to merge 1 commit intobytedance:mainfrom
Conversation
|
|
guhaiyan0221
force-pushed
the
main
branch
2 times, most recently
from
906a3a9 to
b88fc0e
Compare
Summary: Doc: https://spark.apache.org/docs/latest/api/sql/#mode Code: https://github.com/apache/spark/blob/branch-3.5/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Mode.scala#L42 `ComplexTypeAccumulator` needs inputType parameter, which doesn't align with `SimpleAggregateAdapter`'s intializer's signature. So we don't implement the mode function with simple API for complex types. Corresponding PR: facebookincubator/velox#10462
guhaiyan0221
force-pushed
the
fix_cp_mode_agg
branch
from
9dc6017 to
7451b26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: discussion #191
Type of Change
Description
Summary:
Doc: https://spark.apache.org/docs/latest/api/sql/#mode Code: https://github.com/apache/spark/blob/branch-3.5/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Mode.scala#L42
ComplexTypeAccumulatorneeds inputType parameter, which doesn't align withSimpleAggregateAdapter's intializer's signature. So we don't implement the mode function with simple API for complex types.Corresponding PR: facebookincubator/velox#10462
Performance Impact
No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
Positive Impact: I have run benchmarks.
Click to view Benchmark Results
Negative Impact: Explained below (e.g., trade-off for correctness).
Release Note
Please describe the changes in this PR
Release Note:
Checklist (For Author)
Breaking Changes
No
Yes (Description: ...)
Click to view Breaking Changes