[feat][cp] Support read local file async#366
Open
guhaiyan0221 wants to merge 1 commit intobytedance:mainfrom
Open
[feat][cp] Support read local file async#366guhaiyan0221 wants to merge 1 commit intobytedance:mainfrom
guhaiyan0221 wants to merge 1 commit intobytedance:mainfrom
Conversation
Summary: Add struct FileSystemOptions to function registerLocalFileSystem, default readAhead false, Use an executor to submit the read async task, the number thread of pool is half of system concurrency. The performance is same with before when device is SSD, can save about 50% time in HDD. Corresponding PR: facebookincubator/velox#11869
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #191
Type of Change
Description
Summary:
Add struct FileSystemOptions to function registerLocalFileSystem, default readAhead false, Use an executor to submit the read async task, the number thread of pool is half of system concurrency. The performance is same with before when device is SSD, can save about 50% time in HDD.
Corresponding PR: facebookincubator/velox#11869
Performance Impact
Release Note
Please describe the changes in this PR
Release Note:
Checklist (For Author)
Breaking Changes
No
Yes (Description: ...)
Click to view Breaking Changes