Skip to content

[fix][cp] Fix min precision of short decimal type (#9359)#382

Open
WangGuangxin wants to merge 1 commit intobytedance:mainfrom
WangGuangxin:cp_9359
Open

[fix][cp] Fix min precision of short decimal type (#9359)#382
WangGuangxin wants to merge 1 commit intobytedance:mainfrom
WangGuangxin:cp_9359

Conversation

@WangGuangxin
Copy link

@WangGuangxin WangGuangxin commented Mar 11, 2026

What problem does this PR solve?

Issue Number: close #191

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🚀 Performance improvement (optimization)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🔨 Refactoring (no logic changes)
  • 🔧 Build/CI or Infrastructure changes
  • 📝 Documentation only

Description

The min precision of short decimal type should be 1.

Corresponding PR: facebookincubator/velox#9359

Performance Impact

  • No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).

  • Positive Impact: I have run benchmarks.

    Click to view Benchmark Results
    Paste your google-benchmark or TPC-H results here.
    Before: 10.5s
    After:   8.2s  (+20%)
    
  • Negative Impact: Explained below (e.g., trade-off for correctness).

Release Note

Please describe the changes in this PR

Release Note:

Release Note:
- Fixed the min precision of short decimal type should be 1.

Checklist (For Author)

  • I have added/updated unit tests (ctest).
  • I have verified the code with local build (Release/Debug).
  • I have run clang-format / linters.
  • (Optional) I have run Sanitizers (ASAN/TSAN) locally for complex C++ changes.
  • No need to test or manual test.

Breaking Changes

  • No

  • Yes (Description: ...)

    Click to view Breaking Changes
    Breaking Changes:
    - Description of the breaking change.
    - Possible solutions or workarounds.
    - Any other relevant information.
    

@WangGuangxin WangGuangxin changed the title Fix min precision of short decimal type (#9359) [fix][cp] Fix min precision of short decimal type (#9359) Mar 11, 2026
Summary:
The min precision of short decimal type should be 1.

Pull Request resolved: facebookincubator/velox#9359

Reviewed By: xiaoxmeng, amitkdutta

Differential Revision: D55741593

Pulled By: mbasmanova

fbshipit-source-id: 6d5cc0ba38ba0b4ecc976615bdf8a3e5eff5f102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants