[fix][cp] Fix min precision of short decimal type (#9359)#382
Open
WangGuangxin wants to merge 1 commit intobytedance:mainfrom
Open
[fix][cp] Fix min precision of short decimal type (#9359)#382WangGuangxin wants to merge 1 commit intobytedance:mainfrom
WangGuangxin wants to merge 1 commit intobytedance:mainfrom
Conversation
Summary: The min precision of short decimal type should be 1. Pull Request resolved: facebookincubator/velox#9359 Reviewed By: xiaoxmeng, amitkdutta Differential Revision: D55741593 Pulled By: mbasmanova fbshipit-source-id: 6d5cc0ba38ba0b4ecc976615bdf8a3e5eff5f102
frankobe
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #191
Type of Change
Description
The min precision of short decimal type should be 1.
Corresponding PR: facebookincubator/velox#9359
Performance Impact
No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
Positive Impact: I have run benchmarks.
Click to view Benchmark Results
Negative Impact: Explained below (e.g., trade-off for correctness).
Release Note
Please describe the changes in this PR
Release Note:
Checklist (For Author)
Breaking Changes
No
Yes (Description: ...)
Click to view Breaking Changes