Skip to content

[fix][cp] Support date-type partition filter (#9937)#384

Open
WangGuangxin wants to merge 1 commit intobytedance:mainfrom
WangGuangxin:cp_9937
Open

[fix][cp] Support date-type partition filter (#9937)#384
WangGuangxin wants to merge 1 commit intobytedance:mainfrom
WangGuangxin:cp_9937

Conversation

@WangGuangxin
Copy link

@WangGuangxin WangGuangxin commented Mar 12, 2026

What problem does this PR solve?

Issue Number: close #191

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🚀 Performance improvement (optimization)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🔨 Refactoring (no logic changes)
  • 🔧 Build/CI or Infrastructure changes
  • 📝 Documentation only

Description

When the partition column is of date type and a filter is applied on it, below error occurs when trying to convert date string as int. This PR fixes this exception by utilizing castFromDateString with standard cast behavior.

C++ exception with description "Exception: VeloxRuntimeError
Error Source: RUNTIME
Error Code: INVALID_STATE
Reason: Operator::getOutput failed for [operator: TableScan, plan node ID: 0]: Non-whitespace character found after end of conversion: "-10-27"

Corresponding PR: facebookincubator/velox#9937

Performance Impact

  • No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).

  • Positive Impact: I have run benchmarks.

    Click to view Benchmark Results
    Paste your google-benchmark or TPC-H results here.
    Before: 10.5s
    After:   8.2s  (+20%)
    
  • Negative Impact: Explained below (e.g., trade-off for correctness).

Release Note

Checklist (For Author)

  • I have added/updated unit tests (ctest).
  • I have verified the code with local build (Release/Debug).
  • I have run clang-format / linters.
  • (Optional) I have run Sanitizers (ASAN/TSAN) locally for complex C++ changes.
  • No need to test or manual test.

Breaking Changes

  • No

  • Yes (Description: ...)

    Click to view Breaking Changes
    Breaking Changes:
    - Description of the breaking change.
    - Possible solutions or workarounds.
    - Any other relevant information.
    

Summary:
When the partition column is of date type and a filter is applied on it, below
error occurs when trying to convert date string as int. This PR fixes this
exception by utilizing castFromDateString with standard cast behavior.
```
C++ exception with description "Exception: VeloxRuntimeError
Error Source: RUNTIME
Error Code: INVALID_STATE
Reason: Operator::getOutput failed for [operator: TableScan, plan node ID: 0]: Non-whitespace character found after end of conversion: "-10-27"
```
facebookincubator/velox#7084

Pull Request resolved: facebookincubator/velox#9937

Reviewed By: pedroerp

Differential Revision: D57913463

Pulled By: Yuhta

fbshipit-source-id: 7956de4ae122b080ecf80a96cfcf546f8aae7efe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants