Skip to content

[refactor] Introduce ConnectorObjectFactory#397

Open
yingsu00 wants to merge 1 commit intobytedance:mainfrom
yingsu00:connector_refactor_2
Open

[refactor] Introduce ConnectorObjectFactory#397
yingsu00 wants to merge 1 commit intobytedance:mainfrom
yingsu00:connector_refactor_2

Conversation

@yingsu00
Copy link
Contributor

@yingsu00 yingsu00 commented Mar 16, 2026

What problem does this PR solve?

Issue Number: Partially resolves #250

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🚀 Performance improvement (optimization)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🔨 Refactoring (no logic changes)
  • 🔧 Build/CI or Infrastructure changes
  • 📝 Documentation only

Description

Introduce ConnectorObjectFactory

Performance Impact

  • No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).

  • Positive Impact: I have run benchmarks.

    Click to view Benchmark Results
    Paste your google-benchmark or TPC-H results here.
    Before: 10.5s
    After:   8.2s  (+20%)
    
  • Negative Impact: Explained below (e.g., trade-off for correctness).

Release Note

Please describe the changes in this PR

Release Note: None

Checklist (For Author)

  • I have added/updated unit tests (ctest).
  • I have verified the code with local build (Release/Debug).
  • I have run clang-format / linters.
  • (Optional) I have run Sanitizers (ASAN/TSAN) locally for complex C++ changes.
  • No need to test or manual test.

Breaking Changes

  • No

  • Yes (Description: ...)

    Click to view Breaking Changes
    Breaking Changes:
    - Description of the breaking change.
    - Possible solutions or workarounds.
    - Any other relevant information.
    

@yingsu00 yingsu00 force-pushed the connector_refactor_2 branch from 2fd771a to 18185b6 Compare March 16, 2026 12:46
@yingsu00 yingsu00 force-pushed the connector_refactor_2 branch from 18185b6 to 58c3907 Compare March 18, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Design] Refactor Bolt connectors to remove Hive coupling and prepare for pluggable connectors (Bolt) Background

1 participant