[feat][cp][DynamicMerge] Add lazy multi merge#409
Open
guhaiyan0221 wants to merge 2 commits intobytedance:mainfrom
Open
[feat][cp][DynamicMerge] Add lazy multi merge#409guhaiyan0221 wants to merge 2 commits intobytedance:mainfrom
guhaiyan0221 wants to merge 2 commits intobytedance:mainfrom
Conversation
Summary: The `LocalMerge` operator may start only a subset of the sources at a time to limit memory usage. Hence, it performs multiple partial sort-merge operations, each handling a subset of the merge sources. It spills the results produced by each subset and finishes the spill to ensure the order both within and across all spill files for each partial merge. Finally, creates a `ConcatFilesSpillMergeStream` for each group of spill files of each partial merge , setup a `SpillMerger` using those `ConcatFilesSpillMergeStream` to perform the final sort-merge of the outputs. Parts of facebookincubator/velox#13260 Corresponding PR: facebookincubator/velox#13586
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #191
Type of Change
Description
Summary:
The
LocalMergeoperator may start only a subset of the sources at a time to limit memory usage. Hence, it performs multiple partial sort-merge operations, each handling a subset of the merge sources. It spills the results produced by each subset and finishes the spill to ensure the order both within and across all spill files for each partial merge. Finally, creates aConcatFilesSpillMergeStreamfor each group of spill files of each partial merge , setup aSpillMergerusing thoseConcatFilesSpillMergeStreamto perform the final sort-merge of the outputs.Parts of facebookincubator/velox#13260
Corresponding PR: facebookincubator/velox#13586
Performance Impact
No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
Positive Impact: I have run benchmarks.
Click to view Benchmark Results
Negative Impact: Explained below (e.g., trade-off for correctness).
Release Note
Please describe the changes in this PR
Release Note:
Checklist (For Author)
Breaking Changes
No
Yes (Description: ...)
Click to view Breaking Changes