Skip to content

Conversation

@fzhedu
Copy link
Collaborator

@fzhedu fzhedu commented Dec 17, 2025

What problem does this PR solve?

Issue Number: close #41

Type of Change

  • πŸ› Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • πŸš€ Performance improvement (optimization)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • πŸ”¨ Refactoring (no logic changes)
  • πŸ”§ Build/CI or Infrastructure changes
  • πŸ“ Documentation only

Description

Describe your changes in detail.
For complex logic, explain the "Why" and "How".

Performance Impact

  • No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).

  • Positive Impact: I have run benchmarks.

    Click to view Benchmark Results
    Paste your google-benchmark or TPC-H results here.
    Before: 10.5s
    After:   8.2s  (+20%)
    
  • Negative Impact: Explained below (e.g., trade-off for correctness).

Release Note

Please describe the changes in this PR

Release Note:

Release Note:
- fix bug when hash join with filter on lazy vectors
- support pushing down dynamic filters through right join

Checklist (For Author)

  • I have added/updated unit tests (ctest).
  • I have verified the code with local build (Release/Debug).
  • I have run clang-format / linters.
  • (Optional) I have run Sanitizers (ASAN/TSAN) locally for complex C++ changes.
  • No need to test or manual test.

Breaking Changes

  • No

  • Yes (Description: ...)

    Click to view Breaking Changes
    Breaking Changes:
    - Description of the breaking change.
    - Possible solutions or workarounds.
    - Any other relevant information.
    

@fzhedu fzhedu changed the title [bugfix] port hash join tests: fix bugs about lazy vector inputs and … [bugfix] port hash join tests: fix bugs about lazy vector inputs and support pushing down dynamic filter for right join Dec 17, 2025
…support pushing down dynamic filter for right join

Signed-off-by: fangzhuhe <[email protected]>
Signed-off-by: fangzhuhe <[email protected]>
Signed-off-by: fangzhuhe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Filters on LazyVectors in Joins can lead to incorrect results

1 participant