fix(demo-free-layout): reset panel lock after select - #1138
Open
abin-zh wants to merge 1 commit into
Open
Conversation
- clear active flag in onSelect callback - allow reopening node panel after first successful selection
abin-zh
requested review from
YuanHeDx,
dragooncjw,
louisyoungx,
luics,
sanmaopep and
xiamidaxia
as code owners
May 25, 2026 16:46
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the free layout demo issue where the node selection panel cannot be reopened from a port click after the first successful selection.
The panel lock state (
active) was only reset on close, not on select. This update resets the lock in the select path as well, so subsequent port clicks can continue to open the panel as expected.Fixes #1106.
Validation
node common/scripts/install-run-rush.js updatenode common/scripts/install-run-rush.js buildnode common/scripts/install-run-rush.js lintcd apps/demo-free-layout && npm testnode common/scripts/install-run-rush.js build --to @flowgram.ai/demo-free-layoutnode common/scripts/install-run-rush.js ts-check --to @flowgram.ai/demo-free-layoutnode common/scripts/install-run-rush.js lint --to @flowgram.ai/demo-free-layoutgit diff --check