fix(free-layout): emit content changes for global variable edits - #1148
Open
Gujiassh wants to merge 1 commit into
Open
fix(free-layout): emit content changes for global variable edits#1148Gujiassh wants to merge 1 commit into
Gujiassh wants to merge 1 commit into
Conversation
Gujiassh
requested review from
YuanHeDx,
dragooncjw,
louisyoungx,
luics,
sanmaopep and
xiamidaxia
as code owners
July 10, 2026 09:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #986.
Global variable edits in free-layout were changing variable state without triggering the preset
onContentChangecallback, so autosave and other content listeners could miss updates from the variable panel.Changes
GlobalScopelist/value updates into the presetonContentChangecallback when the variable engine is enabledonContentChangefiresChecklist
Release Impact
Free-layout editors that enable the variable engine now receive
onContentChangecallbacks when global variables are edited from the variable panel.Validation
cd packages/client/free-layout-editor && npm testcd packages/client/free-layout-editor && npm run ts-checkcd packages/client/free-layout-editor && npm run buildgit diff --check