fix(export): preserve lines SVG viewBox on fixed-layout export - #1163
Open
ktz03 wants to merge 1 commit into
Open
fix(export): preserve lines SVG viewBox on fixed-layout export#1163ktz03 wants to merge 1 commit into
ktz03 wants to merge 1 commit into
Conversation
ktz03
requested review from
YuanHeDx,
dragooncjw,
louisyoungx,
luics,
sanmaopep and
xiamidaxia
as code owners
August 19, 2026 09:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed-layout image export cloned the live lines layer but then overwrote the SVG
viewBoxwith a hardcoded0 0 1000 1000.On canvas,
FlowLinesLayersetsviewBoxfrom the current zoom (1000 / finalScale). Forcing1000 x 1000during export mis-scales connection paths relative to nodes, which shows up as crooked lines in exported PNG/SVG/JPEG.This change keeps the cloned viewBox from the live canvas.
Fixes #1146
Testing plan