fix: [#91] Fix build success detection for negative exit codes#390
Open
nandanosql wants to merge 1 commit into
Open
fix: [#91] Fix build success detection for negative exit codes#390nandanosql wants to merge 1 commit into
nandanosql wants to merge 1 commit into
Conversation
The regex in _execute_interactive used (\d+) to capture exit codes, which fails to match negative numbers like -1 (returned on timeout). Changed to (-?\d+) to allow optional leading minus sign, enabling proper detection of both success (0) and failure (non-zero, including negative codes like -1 for errors/timeouts).
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #91
Problem
In
docker_manager.py, the_execute_interactivemethod uses regex(\d+)to capture the exit code from shell commands. This fails to match negative exit codes like-1(returned on timeout or error), causing the success detection to be incorrect.Solution
Changed the regex from
(\d+)to(-?\d+)to allow an optional leading minus sign. This enables proper detection of:0-1)Changes
docker_manager.pyline ~183: Changed regex pattern fromr"(\d+)"tor"(-?\d+)"