Skip to content

fix: escape path in find command to prevent shell injection #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hobostay wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: escape path in find command to prevent shell injection #402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion trae_agent/tools/edit_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#
# This modified file is released under the same license.

import shlex
from pathlib import Path
from typing import override

Expand Down Expand Up @@ -159,7 +160,9 @@ async def _view(self, path: Path, view_range: list[int] | None = None) -> ToolEx
"The `view_range` parameter is not allowed when `path` points to a directory."
)

return_code, stdout, stderr = await run(rf"find {path} -maxdepth 2 -not -path '*/\.*'")
return_code, stdout, stderr = await run(
rf"find {shlex.quote(str(path))} -maxdepth 2 -not -path '*/\.*'"
)
if not stderr:
stdout = f"Here's the files and directories up to 2 levels deep in {path}, excluding hidden items:\n{stdout}\n"
return ToolExecResult(error_code=return_code, output=stdout, error=stderr)
Expand Down