fix(evaluation): Support direct run_evaluation script execution#415
Open
Gujiassh wants to merge 1 commit into
Open
fix(evaluation): Support direct run_evaluation script execution#415Gujiassh wants to merge 1 commit into
Gujiassh wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The evaluation README tells users to run
python run_evaluation.pyfrom theevaluationdirectory, butrun_evaluation.pyonly used a package-relative import. Direct script execution therefore failed before argument parsing withImportError: attempted relative import with no known parent package.This PR keeps the package import path for
python -m evaluation.run_evaluationand adds a direct-script import path for the documentedpython run_evaluation.pyinvocation.More Information
__package__check at the top ofevaluation/run_evaluation.py.sys.pathandevaluation.utilsis imported by absolute package name.runpy.run_pathand stubs optional heavy evaluation dependencies.Validation
uv sync --extra test --extra evaluation uv run pytest tests/test_evaluation_entrypoint.py uv run pytest tests/test_evaluation_entrypoint.py tests/test_cli.py uv run ruff check evaluation/run_evaluation.py tests/test_evaluation_entrypoint.py uv run python -m py_compile evaluation/run_evaluation.py tests/test_evaluation_entrypoint.py git diff --checkLinked Issues
Fixes #371