Update to Scala 3.4.0#76
Open
davoclavo wants to merge 2 commits into
Open
Conversation
davoclavo
force-pushed
the
update_to_scala_3_4_0
branch
2 times, most recently
from
94a1c59 to
b95787f
Compare
Due to multiple new warnings: - Added infix modifier for commonly used infix operators and types - Replaced `: _*` for `*` Due to new compilation errors: - Added Promotion `(T, DType) => T` -- match types are behaving slightly different now. - Although I'm still unsure what are the implications of this change everything runs properly
davoclavo
force-pushed
the
update_to_scala_3_4_0
branch
from
b95787f to
dc691f0
Compare
Collaborator
|
Hey thanks @davoclavo and sorry for missing this. I'm a bit hesitant to move to 3.4 already as I think it can't be used from someone on 3.3 LTS if I understand the compat rules correctly. |
Contributor
Author
|
Hey @sbrunk no worries! Happy to leave this PR in the back burner for now, until a solution for the problem you mentioned is found. Is cross compilation to multiple versions something that might be worth looking into? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Here are some changes to update to Scala 3.4.0.
Match types seem to be behaving slightly different now, I wonder what improvements could be adopted in the future.
Some changes:
infixmodifier for commonly used infix operators and types - the other option is to remove theinfixmodifier and instead surround the infix operand with backticks: _*for*(T, DType) => T- Although I'm still unsure what are the implications of this change everything runs properly in my machine