Fix --get-archive=arc not waiting for ACK #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the DMPAFT command has been sent and the ACK has been received, the driver was sending the date and was waiting for the ACK only for a few CPU cycles, not enough for the davis to process the request. A separate ReadBufferWithTimeout function was added to block the execution and wait for the incomming bytes before timing out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the DMPAFT command has been sent and the ACK has been received, the driver was sending the date and was waiting for the ACK only for a few CPU cycles, not enough for the davis to process the request. A separate ReadBufferWithTimeout function was added to block the execution and wait for the incomming bytes before timing out.