Skip to content

Multithreading#35

Merged
BTV25 merged 14 commits intomasterfrom
multithreading
Sep 4, 2025
Merged

Multithreading#35
BTV25 merged 14 commits intomasterfrom
multithreading

Conversation

@BTV25
Copy link
Copy Markdown
Member

@BTV25 BTV25 commented Sep 2, 2025

Accelerate non FMM code

@BTV25 BTV25 requested review from Copilot and rymanderson September 2, 2025 00:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements multithreading to accelerate non-FMM code in the FLOWVPM package, improving performance for parallel particle computations.

  • Adds multithreading support to particle update loops using Threads.@threads
  • Refactors particle state updates into separate functions with thread-safe implementations
  • Optimizes data access patterns by replacing iterator-based operations with direct array views

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
test/runtests_singlevortexring.jl Updates FMM configuration parameters for testing
src/FLOWVPM_utils.jl Replaces iterator-based array comprehensions with direct array views and adds documentation
src/FLOWVPM_timeintegration.jl Implements multithreading for particle updates and refactors into thread-safe functions
src/FLOWVPM_subfilterscale.jl Adds documentation for ConstantSFS struct
src/FLOWVPM_particlefield.jl Removes internal memory array M and fixes static particle condition checks

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/FLOWVPM_particlefield.jl Outdated
Comment thread src/FLOWVPM_particlefield.jl Outdated
Comment thread src/FLOWVPM_timeintegration.jl Outdated
Comment thread src/FLOWVPM_timeintegration.jl Outdated
Comment thread src/FLOWVPM_timeintegration.jl Outdated
Comment thread src/FLOWVPM_timeintegration.jl Outdated
Comment thread src/FLOWVPM_timeintegration.jl
Comment thread src/FLOWVPM_timeintegration.jl Outdated
Comment thread src/FLOWVPM_particlefield.jl Outdated
Comment thread src/FLOWVPM_particlefield.jl Outdated
Comment thread src/FLOWVPM_subfilterscale.jl Outdated
Comment thread src/FLOWVPM_subfilterscale.jl Outdated
Comment thread src/FLOWVPM_subfilterscale.jl Outdated
Comment thread src/FLOWVPM_subfilterscale.jl Outdated
Comment thread src/FLOWVPM_subfilterscale.jl Outdated
@BTV25 BTV25 merged commit 0379fe7 into master Sep 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants