Improve performance by caching diffs and avoiding unnecessary moment copies #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesarizu
force-pushed
the
diff-cache
branch
3 times, most recently
from
9c62a07 to
87a3384
Compare
Author
|
@c-trimm I've rebased this branch to the latest master, is there anything else missing or anything you'd like me to do to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves moment-recur performance by caching diffs and avoiding unnecessary moment copies.
The diff caching is done on a simple js object. In long-lived applications this might mean a ever increasing memory usage. There's the option of using https://www.npmjs.com/package/caching-map or a similar library to avoid this problem.