Skip to content

feat: Replace window.confirm() with styled ConfirmDialog component#274

Open
JamalMohamedR wants to merge 1 commit intoc2siorg:mainfrom
JamalMohamedR:feat/confirm-dialog
Open

feat: Replace window.confirm() with styled ConfirmDialog component#274
JamalMohamedR wants to merge 1 commit intoc2siorg:mainfrom
JamalMohamedR:feat/confirm-dialog

Conversation

@JamalMohamedR
Copy link
Copy Markdown

Description

Replaces all window.confirm() usages with a reusable, styled HTML confirmation modal component (ConfirmDialog). The native browser dialog was visually inconsistent with the application's UI and appeared differently across operating systems.

This change introduces a consistent, accessible, and reusable confirmation pattern aligned with the app’s design system.

Fixes #273


Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

How Has This Been Tested?

Manually verified both trigger points in the browser:

  • Clicked New button in the toolbar → custom HTML modal appeared (not browser dialog) → Cancel keeps workspace, Confirm clears it ✅

  • Opened Share Pipeline → added code → clicked Load Pipeline with existing blocks → custom modal appeared → Cancel aborts, Confirm loads pipeline ✅

  • Existing tests pass

  • New tests added

  • Manual testing


Screenshots (if applicable)

output output1

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review
  • I have added/updated documentation as needed
  • My changes generate no new warnings
  • Tests pass locally

@JamalMohamedR JamalMohamedR force-pushed the feat/confirm-dialog branch 2 times, most recently from a2c3468 to d694648 Compare March 26, 2026 11:10
@ivantha
Copy link
Copy Markdown
Member

ivantha commented Apr 13, 2026

Thanks for the PR! It currently has merge conflicts with main (or is behind). Could you rebase onto the latest main and push the updated branch? Happy to merge once it's auto-rebasable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] feat: Replace window.confirm() with styled ConfirmDialog component

3 participants