feat: Replace window.confirm() with styled ConfirmDialog component#274
Open
JamalMohamedR wants to merge 1 commit intoc2siorg:mainfrom
Open
feat: Replace window.confirm() with styled ConfirmDialog component#274JamalMohamedR wants to merge 1 commit intoc2siorg:mainfrom
JamalMohamedR wants to merge 1 commit intoc2siorg:mainfrom
Conversation
a2c3468 to
d694648
Compare
d694648 to
472db59
Compare
Member
|
Thanks for the PR! It currently has merge conflicts with main (or is behind). Could you rebase onto the latest main and push the updated branch? Happy to merge once it's auto-rebasable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces all
window.confirm()usages with a reusable, styled HTML confirmation modal component (ConfirmDialog). The native browser dialog was visually inconsistent with the application's UI and appeared differently across operating systems.This change introduces a consistent, accessible, and reusable confirmation pattern aligned with the app’s design system.
Fixes #273
Type of Change
How Has This Been Tested?
Manually verified both trigger points in the browser:
Clicked New button in the toolbar → custom HTML modal appeared (not browser dialog) → Cancel keeps workspace, Confirm clears it ✅
Opened Share Pipeline → added code → clicked Load Pipeline with existing blocks → custom modal appeared → Cancel aborts, Confirm loads pipeline ✅
Existing tests pass
New tests added
Manual testing
Screenshots (if applicable)
Checklist