fix(geometric): validate RotateImage scale is positive and finite#322
Open
Jayant-kernel wants to merge 2 commits intoc2siorg:mainfrom
Open
fix(geometric): validate RotateImage scale is positive and finite#322Jayant-kernel wants to merge 2 commits intoc2siorg:mainfrom
Jayant-kernel wants to merge 2 commits intoc2siorg:mainfrom
Conversation
PR ReviewSquashYour PR has 2 commits. Please squash into a single commit. How to fixgit fetch origin
git rebase -i origin/main # mark all but first commit as "squash"
git push --force-with-leaseThis comment updates automatically on each push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
RotateImagesilently corrupting the output whenscaleis zero, negative, or non-finite.With
scale=0,cv2.getRotationMatrix2Dmaps every destination pixel to the image centre, producing a uniform solid-colour output with no error raised. Negative and non-finite values produce similarly unexpected results.This adds the same class of validation already applied to
ScaleImage(issue #302).Fixes #320
Type of Change
How Has This Been Tested?
tests/operators/geometric/test_rotate_image.pyscale=0, negative,inf,-inf,nanall raiseValueErrorChecklist