feat: add pre-run pipeline validation warnings#324
Open
xxivani wants to merge 1 commit intoc2siorg:mainfrom
Open
feat: add pre-run pipeline validation warnings#324xxivani wants to merge 1 commit intoc2siorg:mainfrom
xxivani wants to merge 1 commit intoc2siorg:mainfrom
Conversation
|
Reviewed the validatePipeline logic the channel state tracking approach (colour vs grayscale) looks clean. One thought: what happens if the pipeline has zero steps? Does validatePipeline return empty warnings and skip the modal entirely, or does it still show it? Also noticed the branch is out of date with main — might be worth a rebase before merge to avoid surprises. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a pre-run pipeline validation pass that checks for known operator incompatibilities before sending the pipeline to the backend. A new
validatePipelineutility walks the pipeline steps tracking channel state (colour vs grayscale) and flags operators that will likely fail given their input. Warnings are shown in aPipelineWarningsModalwith a Cancel / Run Anyway choice so the check is never a hard blocker.In reference to pr #198
Fixes #197
Type of Change
How Has This Been Tested?
Tested the following cases manually: grayscale operator into a colour-only block, colour image into a grayscale-only block, missing Read Image block, and a valid pipeline with no warnings (runs immediately without showing the modal).
Screenshots (if applicable)
Checklist