fix: resolve blank landing screen due to hashed css module animations#326
Open
MohamedAli1937 wants to merge 1 commit intoc2siorg:mainfrom
Open
fix: resolve blank landing screen due to hashed css module animations#326MohamedAli1937 wants to merge 1 commit intoc2siorg:mainfrom
MohamedAli1937 wants to merge 1 commit intoc2siorg:mainfrom
Conversation
1b35876 to
88c9520
Compare
536acee to
4b7307f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an issue where the new Landing Screen was displaying as a blank black screen with blurry orbs, rather than showing the intended text and buttons.
The bug occurred because
@keyframes(fadeUp,float1,float2) were defined inside a CSS Module (LandingScreen.module.css), which Vite automatically hashes. However, theLandingScreen.tsxcomponent applies these animations via inline styles using hardcoded string names (e.g.,animation: "fadeUp 0.6s..."), causing the animations to fail and leaving the content stuck atopacity: 0.Changes:
LandingScreen.module.css.fadeUp,float1, andfloat2keyframes to the globalindex.cssstylesheet so they can be correctly targeted by the inline styles.Fixes #325
Type of Change
How Has This Been Tested?
Verified that the animations now correctly execute and the landing screen fades in upon loading the app.
Screenshots (if applicable)
N/A
Checklist