fix: Add access control to DeviceRegistry registration#17
Open
LSUDOKO wants to merge 1 commit intoc2siorg:mainfrom
Open
fix: Add access control to DeviceRegistry registration#17LSUDOKO wants to merge 1 commit intoc2siorg:mainfrom
LSUDOKO wants to merge 1 commit intoc2siorg:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Missing Access Control on Device Registration
Description
This Pull Request addresses a critical security vulnerability in
DeviceRegistry.solwhere theregisterDevicefunction was publicly accessible without any access control.Previously, any Ethereum address could register itself as a valid device. This bypassed the hardware authenticity requirement and allowed attackers to mint forged NFTs by registering malicious device addresses.
Changes Made
1. Inherited
OwnableModified
DeviceRegistryto inherit from OpenZeppelin'sOwnablecontract to introduce a standard access-control mechanism.2. Initialized Owner
Added a constructor to properly initialize the
Ownablestate withmsg.senderas the contract owner.3. Restricted Device Registration
Applied the
onlyOwnermodifier to theregisterDevicefunction to ensure that only the contract owner can register new devices.Impact & Security Gains
fix #13