fix: sanitize claim_id to prevent XSS in claim page HTML response#19
Open
ArshLabs wants to merge 1 commit intoc2siorg:mainfrom
Open
fix: sanitize claim_id to prevent XSS in claim page HTML response#19ArshLabs wants to merge 1 commit intoc2siorg:mainfrom
ArshLabs wants to merge 1 commit intoc2siorg:mainfrom
Conversation
claim_id from the request path was interpolated directly into an HTML string returned by the server with no escaping. A malicious claim ID could inject arbitrary HTML or JavaScript into the page. Added escapeHtml() utility and applied it to all claim_id interpolations in HTML template literals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
lensmint-public-server/server.js,claim_idfrom the request URL is interpolated directly into HTML strings returned to the browser with no sanitization:A malicious actor could craft a URL with a claim ID containing
<script>tags or other HTML, resulting in XSS on anyone who visits the claim page.Fix
Added a minimal
escapeHtml()utility function and applied it to allclaim_idinterpolations inside HTML template literals. Also escapederror.messagein the error page response.