fix: add frontend validation for Dropout rate and Input layer dimensions#283
Open
Rkx-01 wants to merge 1 commit intoc2siorg:mainfrom
Open
fix: add frontend validation for Dropout rate and Input layer dimensions#283Rkx-01 wants to merge 1 commit intoc2siorg:mainfrom
Rkx-01 wants to merge 1 commit intoc2siorg:mainfrom
Conversation
Rkx-01
force-pushed
the
fix/frontend-layer-validation
branch
from
6f7f27c to
cd55c95
Compare
Member
|
This PR's head branch is behind |
Rkx-01
force-pushed
the
fix/frontend-layer-validation
branch
2 times, most recently
from
0827cad to
a001891
Compare
Contributor
Author
|
Hi @ivantha! The branch has been fully cleaned up: rebased onto latest main, squashed into a single commit, all lint/format checks passing. Ready to merge! |
Addresses c2siorg#263. Three validation gaps allowed invalid models to be built silently: - Dropout rate had no lower/upper bound enforcement; users could type values like 5 or -1 which the backend rejects with HTTP 400 - Input layer dimension inputs accepted 0 and negative values which are invalid for Keras input shapes - canSaveModel() in Helpers.jsx had no guard for dropout nodes, so a model with an unconfigured or out-of-range dropout rate could still be saved Changes: - NodePropertiesPanel.jsx: clamp Dropout rate to [0, 0.9] on input; enforce min=1 and integer-only values for all Input layer dimensions - Helpers.jsx: add custominput positive-integer guard and customdropout rate validation to canSaveModel() so the Save button stays disabled until all params are valid
Rkx-01
force-pushed
the
fix/frontend-layer-validation
branch
from
010b32a to
dc051cd
Compare
Contributor
Author
|
Hi @ivantha! The branch has been fully cleaned up: rebased onto latest main, squashed into a single commit, all lint/format checks passing. Ready to merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 for fixing #263.
Changes:
canSaveModel()with input integer checks and dropout rate validations so models cannot be saved with invalid inputs