Skip to content

feat: add LSTM layer with purple node color#302

Open
Sickwoman wants to merge 1 commit intoc2siorg:mainfrom
Sickwoman:feature/add-lstm-layer-v2
Open

feat: add LSTM layer with purple node color#302
Sickwoman wants to merge 1 commit intoc2siorg:mainfrom
Sickwoman:feature/add-lstm-layer-v2

Conversation

@Sickwoman
Copy link
Copy Markdown
Contributor

@Sickwoman Sickwoman commented Apr 23, 2026

  • Add customlstm node type (units + returnSequences params)
  • Purple color rgb(139,92,246) distinct from all existing nodes
  • LSTMNode component with configured/unconfigured display
  • NodePropertiesPanel with units (max 10000) + returnSequences
  • canSaveModel refactored to validation map pattern
  • Strong validation: NaN, zero, negative units all blocked
  • Backend _build_layer handles customlstm with safe int parsing
  • Backend _build_layer handles customdropout
  • 5 backend tests in test_lstm_layer.py
  • 10 frontend tests covering edge cases

Description

Brief summary of the changes. Reference any related issues.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

How Has This Been Tested?

Describe the tests you ran to verify your changes.

  • Existing tests pass
  • New tests added
  • Manual testing

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review
  • I have added/updated documentation as needed
  • My changes generate no new warnings
  • Tests pass locally

@Sickwoman Sickwoman force-pushed the feature/add-lstm-layer-v2 branch 2 times, most recently from 9f09d07 to eeb9fc8 Compare April 24, 2026 05:16
@Sickwoman
Copy link
Copy Markdown
Contributor Author

By mistake i didn't rebased it and clicked update branch. Now what should i do @ivantha

@Sickwoman Sickwoman force-pushed the feature/add-lstm-layer-v2 branch from eeb9fc8 to 36519d9 Compare April 27, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants