Skip to content

Harden graph validation before Keras model generation#306

Open
shivv23 wants to merge 2 commits intoc2siorg:mainfrom
shivv23:clean-graph-validation
Open

Harden graph validation before Keras model generation#306
shivv23 wants to merge 2 commits intoc2siorg:mainfrom
shivv23:clean-graph-validation

Conversation

@shivv23
Copy link
Copy Markdown
Contributor

@shivv23 shivv23 commented Apr 24, 2026

Fresh PR rebased onto latest upstream/main with graph validation.

Summary

  • Adds validation for duplicate node IDs
  • Adds validation for unknown edge references
  • Adds validation for input nodes without outgoing edges
  • Adds validation for non-input nodes without incoming edges
  • Adds test coverage

Note: 2 test cases use slightly different error messages than original (unrelated to this change)

@github-actions
Copy link
Copy Markdown

PR Review

Rebase

Merge commits detected — please use rebase instead of merge:

5dddf13 Merge branch 'main' into clean-graph-validation

Squash

Your PR has 2 commits. Please squash into a single commit.

How to fix

git fetch origin
git rebase -i origin/main   # mark all but first commit as "squash"
git push --force-with-lease

This comment updates automatically on each push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant