fix: validate disconnected nodes and exclude input nodes from outputs#320
Open
Rkx-01 wants to merge 1 commit intoc2siorg:mainfrom
Open
fix: validate disconnected nodes and exclude input nodes from outputs#320Rkx-01 wants to merge 1 commit intoc2siorg:mainfrom
Rkx-01 wants to merge 1 commit intoc2siorg:mainfrom
Conversation
…odes from outputs in model_generation.py
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #244
Supersedes #245
Two bugs in model_generation.py silently broke model generation:
Disconnected nodes caused a KeyError crash — BFS never visits
unconnected layers but the code still tries to access them in
keras_tensors
Input nodes were misidentified as outputs — custominput nodes
with no outgoing edges were included in output_ids, producing
malformed Keras models silently
Fix
listing exactly which nodes are disconnected
Testing
Note
Fresh PR as requested by @ivantha from #245.
Rebased on latest main, single clean commit, all checks passing.