chore(frontend): enforce supported node engine range#325
Open
kartikeyg0104 wants to merge 2 commits intoc2siorg:mainfrom
Open
chore(frontend): enforce supported node engine range#325kartikeyg0104 wants to merge 2 commits intoc2siorg:mainfrom
kartikeyg0104 wants to merge 2 commits intoc2siorg:mainfrom
Conversation
PR ReviewRebaseMerge commits detected — please use rebase instead of merge: SquashYour PR has 2 commits. Please squash into a single commit. How to fixgit fetch origin
git rebase -i origin/main # mark all but first commit as "squash"
git push --force-with-leaseThis comment updates automatically on each push. |
There was a problem hiding this comment.
Pull request overview
This PR adds Node/NPM version constraints to the frontend to reduce environment drift and prevent install/build issues caused by incompatible runtimes.
Changes:
- Added
enginesconstraints (node >=22.12.0,npm >=11.7.0) totensormap-frontend/package.json. - Added
tensormap-frontend/.nvmrcpinning Node22.12.0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tensormap-frontend/package.json | Introduces Node/NPM engine constraints for the frontend toolchain. |
| tensormap-frontend/.nvmrc | Pins a specific Node version for local dev environments using nvm. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package.json:node >=22.12.0npm >=11.7.0.nvmrcwith22.12.0.Why
Validation
npm run lintRisk