Skip to content

chore(frontend): enforce supported node engine range#325

Open
kartikeyg0104 wants to merge 2 commits intoc2siorg:mainfrom
kartikeyg0104:chore/frontend-node-engine-guardrails
Open

chore(frontend): enforce supported node engine range#325
kartikeyg0104 wants to merge 2 commits intoc2siorg:mainfrom
kartikeyg0104:chore/frontend-node-engine-guardrails

Conversation

@kartikeyg0104
Copy link
Copy Markdown
Contributor

Summary

  • Added Node/NPM engine constraints to package.json:
    • node >=22.12.0
    • npm >=11.7.0
  • Added .nvmrc with 22.12.0.

Why

  • Tooling stack includes packages with strict Node engine requirements.
  • This reduces environment drift and prevents hard-to-debug native/optional dependency resolution failures.

Validation

  • npm run lint
  • Result: lint passes.

Risk

  • Developers on older Node versions must upgrade before installing/running frontend tooling.

Copilot AI review requested due to automatic review settings April 26, 2026 17:04
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 26, 2026

PR Review

Rebase

Merge commits detected — please use rebase instead of merge:

0fcd3ca Merge branch 'main' into chore/frontend-node-engine-guardrails

Squash

Your PR has 2 commits. Please squash into a single commit.

How to fix

git fetch origin
git rebase -i origin/main   # mark all but first commit as "squash"
git push --force-with-lease

This comment updates automatically on each push.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Node/NPM version constraints to the frontend to reduce environment drift and prevent install/build issues caused by incompatible runtimes.

Changes:

  • Added engines constraints (node >=22.12.0, npm >=11.7.0) to tensormap-frontend/package.json.
  • Added tensormap-frontend/.nvmrc pinning Node 22.12.0.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tensormap-frontend/package.json Introduces Node/NPM engine constraints for the frontend toolchain.
tensormap-frontend/.nvmrc Pins a specific Node version for local dev environments using nvm.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tensormap-frontend/package.json
Comment thread tensormap-frontend/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants