Allow the graph to follow the container vertical resize#2376
Open
jsiembida wants to merge 1 commit intoc3js:masterfrom
jsiembida:vertical-resize-fix
Open
Allow the graph to follow the container vertical resize#2376jsiembida wants to merge 1 commit intoc3js:masterfrom jsiembida:vertical-resize-fix
jsiembida wants to merge 1 commit intoc3js:masterfrom
jsiembida:vertical-resize-fix
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2376 +/- ##
==========================================
- Coverage 77.23% 77.22% -0.01%
==========================================
Files 51 51
Lines 4138 4137 -1
==========================================
- Hits 3196 3195 -1
Misses 942 942
Continue to review full report at Codecov.
|
Contributor
|
Hi @jsiembida, thanks for the contribution. Tests are required for pull requests, it ensures the changes are working as expected and serve as documentation on how the library is supposed to behave for future contributors. Did you find out why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Observed behavior:
When changing the vertical window size the chart only updates towards
smaller height (can only shrink). When the window is getting higher, the chart
stays at the last height. The horizontal resizing works as expected.
This is CodePen (couldn't reproduce it using jsFiddle) of the original C3:
https://codepen.io/anon/pen/aGewNy
This is CodePen with the fix applied:
https://codepen.io/anon/pen/qYejZp
Please drag the horizontal bar up and down and observe how chart follows the resizing.
regards,
jarek