Update updateSvgSize to be less fragile#2525
Open
beninsocrata wants to merge 2 commits intoc3js:masterfrom
Open
Update updateSvgSize to be less fragile#2525beninsocrata wants to merge 2 commits intoc3js:masterfrom
beninsocrata wants to merge 2 commits intoc3js:masterfrom
Conversation
selection.selectAll doesn't support array syntax
Forgot to take out the array brackets in the first commit. The array version is fragile in our platform, so using the common comma separated string of selectors instead.
Codecov Report
@@ Coverage Diff @@
## master #2525 +/- ##
=======================================
Coverage 80.54% 80.54%
=======================================
Files 54 54
Lines 4282 4282
=======================================
Hits 3449 3449
Misses 833 833
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been unable to find the culprit in our system, but something is killing the functionality that allows
d3Selection.selectAll(<array>)on our platform. I have created a fork where I update the.selectAllto use the much more common form of a comma-separated string selector instead of the array of selectors